Allow SpringApplicationRunListeners step action to be optional #22845
Conversation
|
@bclozel There appears to be still a missing call to a Another note I couldn't run the tests locally it was hanging on the |
spring-projects-issues
added
the
status: waiting-for-triage
|
@bclozel spring-projects/spring-framework#25572 (in Spring Framework Repository) fixes the missing call to end. It was the |
|
This one was my fault, I messed up in a polish commit. |
philwebb
added
type: task
mdeinum
force-pushed
the
gh-22776
branch
2 times, most recently
from
6fe8b32 to
d9e0c14
Compare
Prior to this commit the StartupStep.end method was being called from the default step action. However when overriding the default step action this might lead to the StartupStep.end method not being called. As in the case of a failure, as that enriches the information being written. This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution. See: spring-projectsgh-22776
|
Just noticed 4 test failures on Concourse-ci, however, it is 4 times the same test, appears that tests are either counted or run multiple times? The test is failing due to the linked Spring Framework issue. |
philwebb
changed the title
Update `SpringApplicationRunListeners` so that the step action is optional and does not need to call `end()`. This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution. See gh-22845
|
Thanks @mdeinum! I've tweaked the test for now until the Framework issue is fixed. |
Prior to this commit the StartupStep.end method was being
called from the default step action. However when overriding
the default step action this might lead to the StartupStep.end
method not being called. As in the case of a failure, as that
enriches the information being written.
This commit also introduces a test for the failure case showing that
there is a missed call to end with the initial solution.
See: gh-22776