Issue #17766 - change classpath from command line to environment variable when forking #24320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on command line when forking
|
@cquoss Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@cquoss Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
the
for: team-attention
|
We discussed this today as a team and we've decided that unfortunately there are too many downsides to used the environment variable. We think the pathing jar is the best long term solution as it will work with both forked and non-forked processes. We'll leave #17766 open to track that. Thanks anyway for the idea and the PR. |
philwebb
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #17766. Please take into account that this solution would append to any CLASSPATH env var already provided in configuration.
Another solution would be to simply leave the provided classpath env var as it is in such cases.
Then the caller would have to include all maven related classpath items.
In either case an amendment of the goal documentation should be taken into consideration.
Please guide me on how to do so if you find this useful.
Regards
Clemens Quoß