Exclude GradleBuild tasks on JDK 16 for now #25523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
On a related note: Are you planning to eventually upgrade to Gradle 7 in 2.4.x at all? |
We're running against the 7.0 milestones on |
|
Thanks for the follow-up Christoph. Let's see how it goes and we can refine if needed. |
|
And we have a green build ladies and gentlemen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
unfortunately, the first pipeline run on JDK 16 failed due to the gradle-plugin not being built which the
spring-boot-launch-script-testsandspring-boot-loader-testsdepend upon. I've missed this on local tests, because previous runs populated my Gradle caches. I'm sorry for that.As this is only a temporary solution until Gradle 7 is out, I chose to pragmatically disable things for now. There are other ways to fix this. E.g. by extending the toolchain DSL to enforce the compilation step, which would cause the
spring-boot-gradle-pluginJAR to be built. Just let me know if you prefer that and I will play around with that idea.Cheers,
Christoph