Skip to content

MDC trace and span IDs for Brave and OTel #32488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MDC trace and span IDs for Brave and OTel #32488

wants to merge 1 commit into from

Conversation

marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Sep 23, 2022 •
edited
Loading

Conditionals

  • If Micrometer Tracing IS on the classpath
    • For Brave
      • [MDC] If MDC is on the classpath
        • We will setup injecting spanId / traceId to MDC context
    • For OTel:
      • [MDC] If MDC is on the classpath
        • We will setup injecting spanId / traceId to MDC context

superseeds #32214
split from #32480

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2022
@marcingrzejszczak marcingrzejszczak mentioned this pull request Sep 23, 2022
Closed
2 tasks
@wilkinsona
Copy link
Member

I got confused by the separation of the 3 PRs and processed this all in #32480 in the end. Sorry.

@wilkinsona wilkinsona closed this Sep 27, 2022
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcingrzejszczak @wilkinsona @spring-projects-issues