Skip to content

Support service connections for redis/redis-stack and redis/redis-stack-server #41327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Support service connections for redis/redis-stack and redis/redis-stack-server #41327

wants to merge 7 commits into from

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Jul 5, 2024 •
edited
Loading

  • Add new images to RedisDockerComposeConnectionDetailsFactory
  • Support more than one connection name in ContainerConnectionDetailsFactory
  • Add new images to RedisContainerConnectionDetailsFactory

@eddumelendez
Add service connection from redis/redis-stack and redis/redis-stack-s…
8acb5f9 
…erver

* Add new images to `RedisDockerComposeConnectionDetailsFactory`
* Support more than one connection name in `ContainerConnectionDetailsFactory`
* Add new images to `RedisContainerConnectionDetailsFactory`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 5, 2024
@wilkinsona wilkinsona mentioned this pull request Jul 11, 2024
Closed
@wilkinsona
Copy link
Member

Should RedisStackContainer from testcontainers-redis be supported?

I think we should consider support for testcontainers-redis separately. I've opened #41450 for that.

@wilkinsona wilkinsona self-assigned this Jul 17, 2024
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 17, 2024
@wilkinsona wilkinsona added this to the 3.4.x milestone Jul 17, 2024
@wilkinsona wilkinsona mentioned this pull request Jul 17, 2024
Closed
@wilkinsona wilkinsona modified the milestones: 3.4.x, 3.4.0-M1 Jul 17, 2024
wilkinsona pushed a commit that referenced this pull request Jul 17, 2024
@eddumelendez @wilkinsona
Support service connections for redis-stack and redis-stack-server
2634d0c 
See gh-41327
wilkinsona added a commit that referenced this pull request Jul 17, 2024
@wilkinsona
Polish "Support service connections for redis-stack and redis-stack-s…
46ec3e3 
…erver"

See gh-41327
@wilkinsona
Copy link
Member

Thanks very much, @eddumelendez. I moved the support for matching on one of multiple different connection names out into #41543. I also dropped support for bitnami/redis with Testcontainers. We don't have any Bitnami support on the Testcontainers side and I'd prefer that we tackle it separately and consistently or not at all.

@wilkinsona wilkinsona changed the title Add service connection from redis/redis-stack and redis/redis-stack-server Support service connections for redis/redis-stack and redis/redis-stack-server Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@eddumelendez @wilkinsona @spring-projects-issues