Add support for grafana/otel-lgtm and LgtmStackContainer from Service Connection #41551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Thanks for the suggestion but our upgrade policy states we won't upgrade to a new feature release in a maintenance release of Spring Boot. I've upgraded to 1.20.0 on |
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Jul 29, 2024
snicoll
added a commit
that referenced
this pull request
Jul 29, 2024
|
Thanks again @eddumelendez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
grafana/otel-lgtmfrom Docker Compose andLgtmStackContainerfrom Testcontainers' Grafana module as a Service Connection for Metrics
and Tracing with Opentelemetry.
The image provides Loki, Grafana, Tempo, Mimir, Prometheus and Opentelemetry Collector installed, which is nice for local development.
This PR use Testcontainers for Java 1.20.0, which contains the brand new
grafanamodule. The new version works well with previous spring boot versions as you can see here, so, would be great to port it to 3.2.x and 3.3.x branches as well.Thanks!