Skip to content

Add default value for spring.data.web.pageable.serialization-mode to configuration metadata #42410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Sep 22, 2024

See gh-39797

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 22, 2024
@wilkinsona
Copy link
Member

This isn’t needed:

https://docs.spring.io/spring-boot/3.4/appendix/application-properties/index.html#application-properties.data.spring.data.web.pageable.serialization-mode

The annotation processor now collects default values from enum fields.

@wilkinsona wilkinsona closed this Sep 22, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 22, 2024
@izeye
Copy link
Contributor Author

izeye commented Sep 22, 2024

@wilkinsona Ah, sorry. I missed it.

So are the existing manual configuration metadata for enum default values not necessary, for example, spring.jackson.constructor-detector as follows?

{
"name": "spring.jackson.constructor-detector",
"defaultValue": "default"
},

@izeye izeye deleted the polish-gh-39797 branch September 22, 2024 08:57
@wilkinsona
Copy link
Member

Many of the defaults were removed in 788417d as part of #7562. It's entirely possible that we missed some but that doesn't appear to be the case with spring.jackson.constructor-detector as the code has no default value:

/**
* Strategy to use to auto-detect constructor, and in particular behavior with
* single-argument constructors.
*/
private ConstructorDetectorStrategy constructorDetector;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants