Provide a configuration property for configuring Jetty's max form keys #42448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qingbozhang Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@qingbozhang Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
|
Hi I’d appreciate a review when you have a moment. Thanks! |
|
We're a small team with many different priorities. Expecting a review within two days of opening a PR isn't realistic. Someone will review this when we have time. Thank you for your patience in the meantime. |
|
OK, thank you |
snicoll
requested changes
Sep 30, 2024
...autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java
Outdated
Show resolved
Hide resolved
...autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/boot/autoconfigure/web/embedded/JettyWebServerFactoryCustomizer.java
Show resolved
Hide resolved
...ava/org/springframework/boot/autoconfigure/web/embedded/JettyWebServerFactoryCustomizer.java
Show resolved
Hide resolved
snicoll
added
the
status: waiting-for-feedback
Thanks for the feedback! I've made the suggested changes. Please let me know if anything else is needed. |
spring-projects-issues
added
status: feedback-provided
philwebb
pushed a commit
that referenced
this pull request
Oct 3, 2024
Add a new 'server.jetty.max-form-key' property that can be used to configure Jetty's Handler.setMaxFormKeys(...). See gh-42448
philwebb
added a commit
that referenced
this pull request
Oct 3, 2024
|
Thanks very much @qingbozhang |
philwebb
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue in the project related to form submissions, where the number of keys exceeded Jetty's default limit of 1000. I found that there's no way to configure this parameter in the Spring Boot configuration file.
Although I achieved my goal by setting
org.eclipse.jetty.server.Request.maxFormKeys, it doesn't feel like an ideal solution.May I submit a PR to add this configuration option?