Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for background initialization of EntityManagerFactory #7184

Closed
wants to merge 1 commit into from
Closed

Add support for background initialization of EntityManagerFactory #7184

wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Oct 18, 2016

This PR adds support for background initialization of EntityManagerFactory which is triggered by presence of @Primary AsyncTaskExecutor.

Resolves #5619.

@vpavic
Add support for background initialization of EntityManagerFactory
eed8998 
This commit adds support for background initialization of `EntityManagerFactory` which is triggered by presence of `@Primary` `AsyncTaskExecutor`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2016
@snicoll snicoll self-assigned this Oct 18, 2016
@snicoll
Copy link
Member

snicoll commented Oct 24, 2016

Looks good @vpavic, thanks! I do hope we'll be able to get rid of that extra constructor that takes URL persistenceUnitRootLocation so hopefully we should be able to reduce the amount of constructors there...

@snicoll snicoll mentioned this pull request Oct 24, 2016
Closed
@snicoll snicoll added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2016
@snicoll
Copy link
Member

snicoll commented Oct 31, 2016

Thanks for the PR but we prefer to revisit this feature once we have implemented #5082

@snicoll snicoll closed this Oct 31, 2016
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Oct 31, 2016
@vpavic
Copy link
Contributor Author

vpavic commented Oct 31, 2016

@snicoll OK, if that's the case I believe #5619 should be reopened, right?

@snicoll
Copy link
Member

snicoll commented Oct 31, 2016

Good catch, thanks!

@vpavic vpavic deleted the gh-5619 branch August 14, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpavic @snicoll @spring-projects-issues