Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfluxDB exporter to Actuator #7351

Closed
wants to merge 1 commit into from

Conversation

mklimasz
Copy link

@mklimasz mklimasz commented Nov 8, 2016

Since 5688 issue wasn't done for a while, I decided to make my first contribution since I'm working on such configuration anyway.

Configurable implementation of gauge writer to export metrics into InfluxDB.

Fixes gh-5688

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2016
Configurable implementation of gauge writer to export metrics into InfluxDB.

Fixes spring-projectsgh-5688
@philwebb
Copy link
Member

Thanks!

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 15, 2016
@philwebb philwebb added this to the 1.5.0 M1 milestone Nov 15, 2016
@philwebb
Copy link
Member

I polished this a little here. I'm wondering if we should strip out the Builder. It seems a little unnecessary since you can just configure InfluxDB directly. It's also not really a builder since it modifies the existing InfluxDB instance and doesn't create a new one.

@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review status: on-hold We can't start working on this issue yet labels Nov 16, 2016
@mklimasz
Copy link
Author

mklimasz commented Nov 16, 2016

My goal was to make clean configuration wrapper to avoid working on pure influxdb-java library.
But I guess, Builder isn't mandatory and can be removed or InfluxDB instance can be created inside builder (in this case we need as mandatory arguments for influxdb in Builder constructor, like url etc.).
I find 2nd approach better, since we need more informations, like db name. Also there is good option to add tag to Point (for example hostname). It is good for grouping metrics from different hosts, while allowing them to write to the same database (and data stay unique for every writer).

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Nov 30, 2016
@philwebb philwebb modified the milestones: 1.5.0 RC1, 1.5.0 M1 Dec 20, 2016
@philwebb
Copy link
Member

Unfortunately I need to de-scope some issues targeted for Spring Boot 1.5. I'd like to push this back since we want to review metrics in general.

@mklimasz
Copy link
Author

When you finish review metrics and you will find consensus, you can ping me here and I can remake this in correct way.

@izeye
Copy link
Contributor

izeye commented Sep 18, 2017

This looks superseded by #9970 as this is for #5688 which has been already superseded.

@snicoll
Copy link
Member

snicoll commented Sep 18, 2017

Indeed, thanks @izeye !

@snicoll snicoll closed this Sep 18, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: on-hold We can't start working on this issue yet type: enhancement A general enhancement labels Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add InfluxDB exporter to Actuator
5 participants