Produce Dropwizard timer metrics instead of gauges in MetricsFilter #9555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
philwebb
added
status: on-hold
|
Thanks for the PR. We're currently pausing all metrics related work whilst we investigate a new top level Spring Metrics project. |
|
Indeed, thanks. |
snicoll
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4405 in a general way (has nothing to do with DropWizard).
I think there's a strong case to be made that timers are way more appropriate than gauges for these kinds of metrics. Picking one value out of all the requests that are made within 10s (the default flush interval) is absolutely random for production systems.
I've only written one test, since the permutations would be quite a bunch.
I could imagine extracting a class that is responsible for submitting the metrics, which would ease testing, especially the need to test permutations - but maybe you're still fine with the way it is right now, so I didn' bother for now.