Skip to content

Commit

Permalink
Suddenly, test durations do not align anymore. What is going on?
Browse files Browse the repository at this point in the history
  • Loading branch information
mp911de committed Dec 4, 2023
1 parent 4b8fabb commit 42953ce
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ public DefaultParameters(Method method, TypeInformation<?> aggregateType) {
* Creates a new {@link DefaultParameters} instance from the given {@link Method} and aggregate
* {@link TypeInformation}.
*
* @param method must not be {@literal null}.
* @param method must not be {@literal null}.
* @param parameterFactory must not be {@literal null}.
* @param aggregateType must not be {@literal null}.
* @param aggregateType must not be {@literal null}.
* @since 3.2.1
*/
public DefaultParameters(Method method, IntFunction<MethodParameter> parameterFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ void capturesImperativeDurationCorrectly() throws Exception {

repositoryMethodInvoker("findAll").invoke();

assertThat(multicaster.first().getDuration(TimeUnit.MILLISECONDS)).isCloseTo(250, Percentage.withPercentage(10));
assertThat(multicaster.first()
.getDuration(TimeUnit.MILLISECONDS)).isCloseTo(500, Percentage.withPercentage(50));
}

@Test // DATACMNS-1764
Expand All @@ -124,7 +125,8 @@ void capturesReactiveDurationCorrectly() throws Exception {

repositoryMethodInvokerForReactive("findAll").<Flux<TestDummy>> invoke().subscribe();

assertThat(multicaster.first().getDuration(TimeUnit.MILLISECONDS)).isCloseTo(250, Percentage.withPercentage(10));
assertThat(multicaster.first()
.getDuration(TimeUnit.MILLISECONDS)).isCloseTo(500, Percentage.withPercentage(50));
}

@Test // DATACMNS-1764
Expand Down

0 comments on commit 42953ce

Please sign in to comment.