-
Notifications
You must be signed in to change notification settings - Fork 684
Documentation enhancement: Separate examples of methods with special parameters and methods without #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
That is kind of the opposite of what I intended. Instead of separating these categories out they should get better mixed, in order to make clear that filtering by property and limiting by method name or special argument are orthogonal concerns. I'll move this to commons, where the documentation we are talking about resides and will provide a PR. |
schauder
added a commit
that referenced
this issue
Apr 15, 2025
Examples for limitin queries with and without a property argument are now better mixed. This makes it more clear that limiting and filtering by property are orthogonal concerns. Closes #3268
schauder
added a commit
that referenced
this issue
Apr 15, 2025
Examples for limiting queries with and without a property argument are now better mixed. This makes it more clear that limiting and filtering by property are orthogonal concerns. Closes #3268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation of Limiting Query Results can be enhanced with the clarification and comment from schauder.
Current situation:
The examples with parameters inside brackets such as
List<User> findByLastname(Limit limit);
and the examples without parameters inside brackets such asUser findFirstByOrderByLastnameAsc();
appear in the same box of examples.Potential enhancement:
To be more obvious, it could be done like this:
I imagine a potential change could be: (There could be a better way, but this is what I can think of right now.)
Create two boxes of examples:
Box A:
Examples without parameters in brackets.
Box B:
Examples with parameters in brackets.
The text was updated successfully, but these errors were encountered: