Do not register SpringDataWebSettings if pageSerializationMode is default #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault allow application to register their own SpringDataWebSettings without @primary see spring-projects/spring-boot#39797 (comment)
spring-projects-issues
added
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
odrotbohm
pushed a commit
that referenced
this pull request
Aug 27, 2024
We now refrain from registering a SpringDataWebSettings instance as bean in the ApplicationContext if @EnableSpringDataWebSupport is used without an explicit declaration of pageSerializationMode. This allows Spring Boot to use the annotation, but allow the attribute value to be configured via a property at the same time. See spring-projects/spring-boot#39797 (comment) for details. Fixes GH-3054.
|
Thanks for the contribution. This polished and merged. |
mipo256
pushed a commit
to mipo256/spring-data-commons
that referenced
this pull request
Sep 21, 2024
We now refrain from registering a SpringDataWebSettings instance as bean in the ApplicationContext if @EnableSpringDataWebSupport is used without an explicit declaration of pageSerializationMode. This allows Spring Boot to use the annotation, but allow the attribute value to be configured via a property at the same time. See spring-projects/spring-boot#39797 (comment) for details. Fixes spring-projectsGH-3054.
mipo256
pushed a commit
to mipo256/spring-data-commons
that referenced
this pull request
Sep 21, 2024
Related ticket spring-projectsGH-3054.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow application to register their own
SpringDataWebSettingswithout@Primarysee spring-projects/spring-boot#39797 (comment)