Add JavaPoet enhancements #3357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add opinionated builders for return statements and invocations, add introspection type for MethodReturns to reduce checks for e.g. `Optional` and `void` and utilities to construct type names.
| public static TypeName className(ResolvableType resolvableType) { | ||
| return TypeName.get(resolvableType.toClass()); | ||
| } | ||
|
|
There was a problem hiding this comment.
should we also have a parameterized variant?
static TypeName parameterizedClassName(ResolvableType resolvableType) {
if (!resolvableType.hasResolvableGenerics()) {
return typeName(resolvableType);
}
return ParameterizedTypeName.get(type.toClass(), type.resolveGenerics());
}Add tests, refine API contracts and reflect it in the documentation, remove methods that seem useful but are rather polluting the API.
christophstrobl
pushed a commit
that referenced
this pull request
Sep 11, 2025
Add tests, refine API contracts and reflect it in the documentation, remove methods that seem useful but are rather polluting the API. Original Pull Request: #3357
christophstrobl
added a commit
that referenced
this pull request
Sep 11, 2025
Original Pull Request: #3357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add opinionated builders for return statements and invocations, add introspection type for MethodReturns to reduce checks for e.g.
Optionalandvoidand utilities to construct type names.