Skip to content

Refactor DefaultReactiveElasticsearchClient to do request customization with the WebClient. #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Apr 29, 2021 · 1 comment · Fixed by #1795
Closed

Refactor DefaultReactiveElasticsearchClient to do request customization with the WebClient. #1794

sothawo opened this issue Apr 29, 2021 · 1 comment · Fixed by #1795
Assignees
@sothawo
Labels
type: enhancement A general enhancement
Milestone
4.3 M1 (2021.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Apr 29, 2021

Currently DefaultReactiveElasticsearchClient customizes requests after the WebClient has created them. This must be changed so that a request customizer is passed to the created WebClient so that the WebClient calls this customizer when creating requests.

This allows code that directly works with the WebClient by using the ReactiveElasticsearchClient.execute(ReactiveElasticsearchClientCallback<T> callback) method - for example Spring Boot health check - to use the customized requests.
@sothawo sothawo added the type: enhancement A general enhancement label Apr 29, 2021
@sothawo sothawo self-assigned this Apr 29, 2021
@sothawo sothawo mentioned this issue Apr 30, 2021
Merged
sothawo added a commit that referenced this issue Apr 30, 2021
@sothawo
Refactor DefaultReactiveElasticsearchClient to do request customizati…
775bf66 
…on with the WebClient. (#1795)

Original Pull Request #1795 
Closes #1794
@sothawo sothawo added this to the 4.3 M1 (2021.1.0) milestone Apr 30, 2021
sothawo added a commit that referenced this issue Apr 30, 2021
@sothawo
Refactor DefaultReactiveElasticsearchClient to do request customizati…
8ab1a4f 
…on with the WebClient. (#1795)

Original Pull Request #1795
Closes #1794

(cherry picked from commit 775bf66)
@sothawo
Copy link
Collaborator Author

sothawo commented Apr 30, 2021

implemented in main and backported to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.3 M1 (2021.1.0)
1 participant
@sothawo