Added @DynamicTemplates annotation #132
Conversation
|
+1 |
|
+1 |
|
Any news on this? |
|
Is there no other way to define dynamic template mapping in spring-data-elasticsearch other than this pull request ? |
|
Hi, sorry for late reponse. I overlook your comment. I looked for some way to define it but this feature is missing in spring-data-elasticsearch. Thats the reason for this pull request. But you can rewrite it by your own as you wish. |
|
@Rajind are there any news about this feature? We would like to update to newer version of spring-data-elasticsearch but we are blocked by this feature. We will appreciate if you merge it to master and close it. |
|
@mohsinh Do you have any news about this? We will appreciate your collaboration. |
|
Hello, Sorry for late reply. Can you rebase your branch with master ? also you need to add test(s) to cover the feature you are proposing. we will review it asap once you rebase and add some working test. |
Conflicts: src/main/java/org/springframework/data/elasticsearch/core/MappingBuilder.java src/test/java/org/springframework/data/elasticsearch/core/SimpleElasticsearchDateMappingTests.java
|
Hi, I updated code, tests and rebased it to ES 2.1.0 master branch. You can now review it. Thanks. |
|
@mohsinh any news? |
…objects; added JUnit for this
|
I'm waiting for the same! |
|
+1 |
|
@kukisak Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@kukisak Thank you for signing the Contributor License Agreement! |
|
implemented and already merged with #238 |
Hi, I added new DynamicTemplates annotation to enable dynamic mapping of indexAnalyzer and searchAnalyzer on fields annotated like @field(type = FieldType.Object). This is alternative to static mapping via @mapping annotation but more flexible. We found it very useful in our project. Please pull it to master branch if you find it handy.
Petr