Skip to content

#47 - Populate the RevisionType with information from Envers. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

#47 - Populate the RevisionType with information from Envers. #195

wants to merge 3 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Jul 1, 2019

schauder added 3 commits July 1, 2019 12:12
@schauder
#47 - Prepare branch.
09b425c
@schauder
#47 - Refactoring EnversRevisionRepositoryImpl.
630a697 
The refactored version uses a more flexible approach to querying revisions.
This will facilitate the necessary changes for #47.
It also allows to acquire all required information in one query
which at least in theory should be faster.
@schauder
#47 - Populate the RevisionType with information from Envers.
e9ca2ef 
For a given revision r the revision type may now be accessed using

    r.getMetadata().getRevisionType()
@schauder schauder requested a review from odrotbohm July 1, 2019 12:56
avew
avew reviewed Oct 14, 2019
View reviewed changes
Copy link

@avew avew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please release this version

@mp911de mp911de self-assigned this Oct 15, 2019
@mp911de mp911de self-requested a review October 15, 2019 13:03
@SBylemans SBylemans mentioned this pull request Jan 6, 2020
Closed
@bohordo
Copy link

bohordo commented Mar 17, 2020

please release this version

@ISKU
Copy link

ISKU commented Mar 30, 2020

please release this version :D

mp911de pushed a commit that referenced this pull request Apr 7, 2020
@schauder @mp911de
#47 - Refactoring EnversRevisionRepositoryImpl.
90b8fcd 
The refactored version uses a more flexible approach to querying revisions.
This will facilitate the necessary changes for #47.
It also allows to acquire all required information in one query
which at least in theory should be faster.

Original pull request: #195.
mp911de pushed a commit that referenced this pull request Apr 7, 2020
@schauder @mp911de
#47 - Populate the RevisionType with information from Envers.
ee0613e 
For a given revision r the revision type may now be accessed using

    r.getMetadata().getRevisionType()

Original pull request: #195.
mp911de added a commit that referenced this pull request Apr 7, 2020
@mp911de
#47 - Polishing.
3f42c1e 
Replace Stream usage with for-loops. Make inner class static. Reduce Lombok usage in production code.

Reformat code.

Original pull request: #195.
@mp911de
Copy link
Member

mp911de commented Apr 7, 2020

That's merged and polished now.

@mp911de mp911de closed this Apr 7, 2020
@mp911de mp911de deleted the issue/gh-47 branch April 7, 2020 13:26
@mp911de mp911de mentioned this pull request Mar 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avew avew avew left review comments

@odrotbohm odrotbohm Awaiting requested review from odrotbohm

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schauder @bohordo @ISKU @mp911de @avew