Skip to content

JDBC let example.springdata.jdbc.basics.aggregate.AggregateConfiguration use BeforeConvertEvent #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schauder opened this issue Jan 14, 2021 · 0 comments
Closed

JDBC let example.springdata.jdbc.basics.aggregate.AggregateConfiguration use BeforeConvertEvent #599

schauder opened this issue Jan 14, 2021 · 0 comments
Labels
type: enhancement A general enhancement

Comments

@schauder
Copy link
Contributor

This was surfaced by spring-projects/spring-data-relational#902

Currently BeforeSaveEvent is used which only works accidentally because mutable entities are used.
The correct event to use is BeforeConvertEvent

This depends on
spring-projects/spring-data-relational#910
Which actually throws the event in the first place.
@schauder schauder self-assigned this Jan 14, 2021
@schauder schauder added the type: enhancement A general enhancement label Jan 14, 2021
schauder added a commit that referenced this issue Jan 14, 2021
@schauder
Uses BeforeConvertEvent instead of BeforeSaveEvent.
6c4eaf6 
Closes: #599
schauder added a commit that referenced this issue Jan 15, 2021
@schauder
gh-599 Prepare branch.
72891d6
schauder added a commit that referenced this issue Jan 15, 2021
@schauder
Uses BeforeConvertEvent instead of BeforeSaveEvent.
8004adc 
Closes: #599
@schauder schauder linked a pull request Feb 24, 2021 that will close this issue
Uses BeforeConvertEvent instead of BeforeSaveEvent. #601
Closed
@schauder schauder removed their assignment Feb 24, 2021
@mp911de mp911de added the status: blocked An issue that's blocked on an external project change label Feb 25, 2021
mp911de pushed a commit that referenced this issue Apr 13, 2021
@schauder @mp911de
Uses BeforeConvertEvent instead of BeforeSaveEvent.
7d03ea5 
Closes: #599
Original pull request: #601.
@mp911de mp911de removed the status: blocked An issue that's blocked on an external project change label Apr 13, 2021
@mp911de mp911de closed this as completed Apr 13, 2021
mp911de pushed a commit that referenced this issue Apr 19, 2021
@schauder @mp911de
Uses BeforeConvertEvent instead of BeforeSaveEvent.
8f123dc 
Closes: #599
Original pull request: #601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uses BeforeConvertEvent instead of BeforeSaveEvent. spring-projects/spring-data-examples
2 participants
@schauder @mp911de