Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveAndFlush could accept iterable as well [DATAJPA-1574] #1883

Closed
spring-projects-issues opened this issue Jul 18, 2019 · 4 comments
Closed
Assignees
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Vladimir Nemergut opened DATAJPA-1574 and commented

JpaRepository interface only has saveAndFlush method that takes a single instance.

<S extends T> S saveAndFlush(S var1)

Would be handy if an overloaded method exists that takes the iterable, similar to save method, e.g.:

<S extends T> List<S> saveAndFlush(Iterable<S> var1)

<S extends T> List<S> save(Iterable<S> var1);


No further details from DATAJPA-1574

@skrabbenborg
Copy link
Contributor

Hi, I would like to start contributing and this seems like a good issue to start with.

@mp911de mp911de added the status: ideal-for-contribution An issue that a contributor can help us with label Jan 18, 2021
@mp911de
Copy link
Member

mp911de commented Jan 18, 2021

Thanks for letting us know, @skrabbenborg. Feel free to submit a pull request. Also, check out our contribution guide that should get you started on contributing.

@schauder
Copy link
Contributor

And let us know if you have any questions.

@skrabbenborg
Copy link
Contributor

Thank you, I will!

skrabbenborg added a commit to jcoreNL/spring-data-jpa that referenced this issue Jan 19, 2021
skrabbenborg added a commit to jcoreNL/spring-data-jpa that referenced this issue Feb 3, 2021
skrabbenborg added a commit to jcoreNL/spring-data-jpa that referenced this issue Feb 3, 2021
@schauder schauder added type: enhancement A general enhancement and removed type: task A general task labels Feb 25, 2021
@schauder schauder added this to the 2.5 RC1 (2021.0.0) milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants