Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FetchableFluentQueryByPredicate.sortBy and FetachableFluentQueryByExample.sortBy use wrong object reference #2438

Closed
jonyschak opened this issue Feb 13, 2022 · 0 comments
Closed

FetchableFluentQueryByPredicate.sortBy and FetachableFluentQueryByExample.sortBy use wrong object reference #2438

jonyschak opened this issue Feb 13, 2022 · 0 comments
Assignees
@schauder
Labels
type: bug A general bug

Comments

@jonyschak
Copy link
Contributor

The sortBy method in FetchableFluentQueryByPredicate and FetachableFluentQueryByExample calls sort.and(sort) rather than this.sort.and(sort).

This causes the sort to be duplicated and any previous sort to be lost.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 13, 2022
jonyschak added a commit to jonyschak/spring-data-jpa that referenced this issue Feb 13, 2022
@jonyschak
spring-projectsGH-2438 - Prepare branch
f5b1380
jonyschak added a commit to jonyschak/spring-data-jpa that referenced this issue Feb 13, 2022
@jonyschak
Correcting sort object reference in FetchableFluentQueryByExample.sor…
bb76f07 
…tBy and FetchableFluentQueryByPredicate.sortBy

Closes spring-projects#2438
@mp911de mp911de linked a pull request Feb 14, 2022 that will close this issue
Fix use wrong object reference in fluent Query API #2439
Closed
4 tasks
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2022
schauder added a commit that referenced this issue Feb 15, 2022
@schauder
Polishing.
4424414 
See #2438
Original pull request #2439
schauder pushed a commit that referenced this issue Feb 15, 2022
@jonyschak @schauder
Correcting sort object reference in FetchableFluentQueryByExample.sor…
4ed32e8 
…tBy and FetchableFluentQueryByPredicate.sortBy

Closes #2438
Original pull request #2439
schauder added a commit that referenced this issue Feb 15, 2022
@schauder
Polishing.
b85a0a4 
See #2438
Original pull request #2439
schauder pushed a commit that referenced this issue Feb 15, 2022
@jonyschak @schauder
Correcting sort object reference in FetchableFluentQueryByExample.sor…
02937e2 
…tBy and FetchableFluentQueryByPredicate.sortBy

Closes #2438
Original pull request #2439
schauder added a commit that referenced this issue Feb 15, 2022
@schauder
Polishing.
5a4ca13 
See #2438
Original pull request #2439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix use wrong object reference in fluent Query API jonyschak/spring-data-jpa
4 participants
@schauder @mp911de @jonyschak @spring-projects-issues