Fix JPQL parser issues with numeric values #3280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jan 9, 2024
| @@ -0,0 +1,45 @@ | |||
| /* | |||
| * Copyright 2023 the original author or authors. | |||
There was a problem hiding this comment.
3 weeks ago this had been valid ;) - I'll change after rebase.
mp911de
reviewed
Jan 9, 2024
| /** | ||
| * @author Christoph Strobl | ||
| */ | ||
| public abstract class SqlParserTests { |
There was a problem hiding this comment.
How about JpqlParserAndRenderTests?
The samples used to validate MOD parsing in tests does not comply with the specification and falsely uses '/' instead of ',' as delimiter. Definition is: expression ::= MOD(arithmetic_expression, arithmetic_expression) See: https://eclipse.dev/eclipselink/api/4.0/eclipselink/org/eclipse/persistence/jpa/jpql/parser/ModExpression.html
This reverts commit 3cac506.
Allow using java string literals using escaped double quotes next to single quoted values.
christophstrobl
force-pushed
the
issue/3277
branch
from
e7bfe98
to
3626638
Compare
mp911de
changed the title
mp911de
pushed a commit
that referenced
this pull request
Jan 10, 2024
The samples used to validate MOD parsing in tests does not comply with the specification and falsely uses '/' instead of ',' as delimiter. Definition is: expression ::= MOD(arithmetic_expression, arithmetic_expression) See: https://eclipse.dev/eclipselink/api/4.0/eclipselink/org/eclipse/persistence/jpa/jpql/parser/ModExpression.html Closes #3277 Original pull request: #3280
mp911de
pushed a commit
that referenced
this pull request
Jan 10, 2024
The samples used to validate MOD parsing in tests does not comply with the specification and falsely uses '/' instead of ',' as delimiter. Definition is: expression ::= MOD(arithmetic_expression, arithmetic_expression) See: https://eclipse.dev/eclipselink/api/4.0/eclipselink/org/eclipse/persistence/jpa/jpql/parser/ModExpression.html Closes #3277 Original pull request: #3280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3277
Fixes: #3308