Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little bit refactoring #3638

Closed
wants to merge 1 commit into from
Closed

Conversation

jack5505
Copy link

@jack5505 jack5505 commented Oct 12, 2024

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 12, 2024
@mp911de
Copy link
Member

mp911de commented Oct 14, 2024

What exactly is the pull request supposed to fix? Care to elaborate?

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Oct 14, 2024
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Oct 21, 2024
@mp911de
Copy link
Member

mp911de commented Oct 21, 2024

Our API is non-null by default. There's no reason to introduce Jakarta Validation API to our infrastructure components.

@mp911de mp911de closed this Oct 21, 2024
@jack5505 jack5505 deleted the refactor branch October 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants