Polishing.

Avoid duplicate query mapping for document replacement operations when the filter query can be determined from the already mapped _id field. See #4707 Original pull request: #4719
spring-projects · Jun 12, 2024 · 1f94b36 · 1f94b36
1 parent 908e87b
commit 1f94b36
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java
@@ -1603,9 +1603,7 @@ protected Object saveDocument(String collectionName, Document dbDoc, Class<?> en
 				MongoPersistentEntity<?> entity = mappingContext.getPersistentEntity(entityClass);
 				UpdateContext updateContext = queryOperations.replaceSingleContext(mapped, true);
 				Document replacement = updateContext.getMappedUpdate(entity);
-
-				Document filter = updateContext.getMappedQuery(entity);
-
+				Document filter = updateContext.getReplacementQuery();
 				if (updateContext.requiresShardKey(filter, entity)) {
 
 					if (entity.getShardKey().isImmutable()) {

diff --git a/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/QueryOperations.java b/spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/QueryOperations.java
@@ -400,7 +400,7 @@ private Document evaluateFields(@Nullable MongoPersistentEntity<?> entity) {
 
 			for (Entry<String, Object> entry : fields.entrySet()) {
 
-				if (entry.getValue()instanceof MongoExpression mongoExpression) {
+				if (entry.getValue() instanceof MongoExpression mongoExpression) {
 
 					AggregationOperationContext ctx = entity == null ? Aggregation.DEFAULT_CONTEXT
 							: new RelaxedTypeBasedAggregationOperationContext(entity.getType(), mappingContext, queryMapper);
@@ -809,13 +809,23 @@ ReplaceOptions getReplaceOptions(@Nullable Class<?> domainType, @Nullable Consum
 
 		@Override
 		<T> Document getMappedQuery(@Nullable MongoPersistentEntity<T> domainType) {
+			return applyIsolation(super.getMappedQuery(domainType));
+		}
 
-			Document mappedQuery = super.getMappedQuery(domainType);
+		/**
+		 * A replacement query that is derived from the already {@link MappedDocument}.
+		 *
+		 * @return
+		 */
+		Document getReplacementQuery() {
+			return applyIsolation(getQueryObject());
+		}
 
+		private Document applyIsolation(Document mappedQuery) {
 			if (multi && update != null && update.isIsolated() && !mappedQuery.containsKey("$isolated")) {
+				mappedQuery = new Document(mappedQuery);
 				mappedQuery.put("$isolated", 1);
 			}
-
 			return mappedQuery;
 		}
 

diff --git a/...ta-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveMongoTemplate.java b/...ta-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveMongoTemplate.java
@@ -1649,7 +1649,7 @@ protected Mono<Object> saveDocument(String collectionName, Document document, Cl
 
 				MongoPersistentEntity<?> entity = mappingContext.getPersistentEntity(entityClass);
 				UpdateContext updateContext = queryOperations.replaceSingleContext(mapped, true);
-				Document filter = updateContext.getMappedQuery(entity);
+				Document filter = updateContext.getReplacementQuery();
 				Document replacement = updateContext.getMappedUpdate(entity);
 
 				Mono<Document> deferredFilter;

diff --git a/...data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java b/...data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java
@@ -728,7 +728,7 @@ private Object convertIdField(Field documentField, Object source) {
 			} else if (isKeyword(key)) {
 				resultDbo.put(key, convertIdField(documentField, entry.getValue()));
 			} else {
-				if(documentField.getProperty() != null && documentField.getProperty().isEntity()) {
+				if (documentField.getProperty() != null && documentField.getProperty().isEntity()) {
 					Field propertyField = createPropertyField(documentField.getPropertyEntity(), key, mappingContext);
 					resultDbo.put(key, getMappedValue(propertyField, entry.getValue()));
 				} else {

diff --git a/...-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoTemplateTests.java b/...-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoTemplateTests.java
@@ -1416,7 +1416,7 @@ public void storesAndRemovesTypeWithComplexId() {
 		id.id = Instant.now().minusSeconds(2);
 		id.first = "foo";
 		id.second = "bar";
-		id.time = Instant.now().minusSeconds(3);
+		id.id = Instant.now().minusSeconds(3);
 
 		TypeWithMyId source = new TypeWithMyId();
 		source.id = id;
@@ -4423,7 +4423,7 @@ static class MyId {
 
 		String first;
 		String second;
-		Instant time;
+		Instant id;
 
 		@Field("t") Instant time;
 	}