Skip to content

Fix missing query options when calling MongoOperations#count. #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix missing query options when calling MongoOperations#count. #4378

wants to merge 2 commits into from

Conversation

@christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Apr 28, 2023

This PR makes sure to forward maxTimeMsec and comment options from the Query to CountOptions.

Closes: #4374

@christophstrobl
Prepare issue branch
1eb73d7
@christophstrobl
Fix missing query options when calling MongoOperations#count.
af8fb32 
This commit makes sure to forward maxTimeMsec and comment options from the query to the CountOptions.
@mp911de mp911de added the type: bug A general bug label May 10, 2023
@mp911de mp911de added this to the 3.4.12 (2021.2.12) milestone May 11, 2023
mp911de pushed a commit that referenced this pull request May 11, 2023
@christophstrobl @mp911de
Fix missing query options when calling MongoOperations#count.
ec55e28 
This commit makes sure to forward maxTimeMsec and comment options from the query to the CountOptions.

Closes: #4374
Original pull request: #4378
mp911de added a commit that referenced this pull request May 11, 2023
@mp911de
Polishing.
7778077 
Introduce has…() and getRequired…() methods for comment and max time limit to remove code duplications.

See #4374
Original pull request: #4378
mp911de pushed a commit that referenced this pull request May 11, 2023
@christophstrobl @mp911de
Fix missing query options when calling MongoOperations#count.
629dfc1 
This commit makes sure to forward maxTimeMsec and comment options from the query to the CountOptions.

Closes: #4374
Original pull request: #4378
mp911de added a commit that referenced this pull request May 11, 2023
@mp911de
Polishing.
776dade 
Introduce has…() and getRequired…() methods for comment and max time limit to remove code duplications.

See #4374
Original pull request: #4378
mp911de pushed a commit that referenced this pull request May 11, 2023
@christophstrobl @mp911de
Fix missing query options when calling MongoOperations#count.
a21fca7 
This commit makes sure to forward maxTimeMsec and comment options from the query to the CountOptions.

Closes: #4374
Original pull request: #4378
mp911de added a commit that referenced this pull request May 11, 2023
@mp911de
Polishing.
6a9163d 
Introduce has…() and getRequired…() methods for comment and max time limit to remove code duplications.

See #4374
Original pull request: #4378
@mp911de mp911de closed this May 11, 2023
@mp911de mp911de deleted the issue/4374 branch May 11, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: bug A general bug

Projects

None yet

Milestone

3.4.12 (2021.2.12)

Development

Successfully merging this pull request may close these issues.

count() $maxTimeMS not work

3 participants

@christophstrobl @mp911de