Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply type conversion to id types when serializing querydsl queries. #4721

Closed
wants to merge 3 commits into from
Closed

Apply type conversion to id types when serializing querydsl queries. #4721

wants to merge 3 commits into from

Conversation

christophstrobl
Copy link
Member

This PR makes sure to apply type conversion.
However the disabled tests is somehow worrysome.

@christophstrobl
Prepare issue branch.
7493355
@christophstrobl
Apply type conversion to id types.
fcaa4ed 
This commit makes sure to convert the generated query into the target type.
@christophstrobl
Disable test that might be false.
9f2c0e5
@mp911de mp911de added this to the 4.2.7 (2023.1.7) milestone Jun 11, 2024
@mp911de mp911de linked an issue Jun 11, 2024 that may be closed by this pull request
SpringDataMongodbQuery and SpringDataMongodbSerializer apply mapping twice #4709
Closed
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Apply type conversion to id types.
4ca008d 
This commit makes sure to convert the generated query into the target type.

Closes #4709
Original pull request: #4721
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
bbef940 
Reformat code, revise nullability declarations.

See #4709
Original pull request: #4721
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Apply type conversion to id types.
8ffa40c 
This commit makes sure to convert the generated query into the target type.

Closes #4709
Original pull request: #4721
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
b10905a 
Reformat code, revise nullability declarations.

See #4709
Original pull request: #4721
mp911de pushed a commit that referenced this pull request Jun 11, 2024
@christophstrobl @mp911de
Apply type conversion to id types.
9752eba 
This commit makes sure to convert the generated query into the target type.

Closes #4709
Original pull request: #4721
mp911de added a commit that referenced this pull request Jun 11, 2024
@mp911de
Polishing.
966277e 
Reformat code, revise nullability declarations.

See #4709
Original pull request: #4721
@mp911de mp911de marked this pull request as ready for review June 11, 2024 13:22
@mp911de
Copy link
Member

mp911de commented Jun 11, 2024

That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 11, 2024
@mp911de mp911de deleted the issue/4709 branch June 11, 2024 13:22
@mp911de mp911de added the type: bug A general bug label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
4.2.7 (2023.1.7)
Development

Successfully merging this pull request may close these issues.

SpringDataMongodbQuery and SpringDataMongodbSerializer apply mapping twice
2 participants
@christophstrobl @mp911de