Support for sorting simple arrays (integers/strings) with SortArray (Fixes #4929) #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray (Fixes spring-projects#4929) - Added methods `byValueAscending()` and `byValueDescending()` to the SortArray class to support sorting simple array types (e.g., integers, strings) in ascending and descending order. - Updated tests to verify the correct functionality of sorting arrays by value. - Refactored SortArray to handle sorting of simple types without requiring a property for sorting. For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/ Signed-off-by: Ranzy Blessings <ranzyblessings.inbox@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
|
Hello team, I’ve addressed the issue with sorting simple arrays (integers/strings) in PR #4943. The fix includes the addition of the byValueAscending() and byValueDescending() methods, along with updated tests to ensure correct functionality. Please don’t hesitate to reach out if any further modifications or adjustments are needed. I’m happy to make any necessary changes. Best regards, Fixes #4929 |
|
Thank you @ranzyblessings! we'll have a look. |
|
Thanks @christophstrobl! Let me know if anything needs adjusting. Also, just a heads-up on the |
ranzyblessings
added a commit
to ranzyblessings/spring-data-mongodb
that referenced
this pull request
Apr 11, 2025
…ixes spring-projects#4929) spring-projects#4943 - Removed unnecessary whitespaces - Added methods byValueAscending() and byValueDescending() to the SortArray class to support sorting simple array types (e.g., integers, strings) in ascending and descending order. - Updated tests to verify the correct functionality of sorting arrays by value. - Refactored SortArray to handle sorting of simple types without requiring a property for sorting. - Removed unnecessary whitespaces and formatting changes to ensure clean, readable code. For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/ Signed-off-by: Ranzy Blessings <ranzyblessings.inbox@gmail.com>
…h SortArray (Fixes spring-projects#4929) to cleanup excessive formatting" This reverts commit 0422055. Signed-off-by: Ranzy Blessings <ranzyblessings.inbox@gmail.com>
…ixes spring-projects#4929) spring-projects#4943 - Removed unnecessary whitespaces - Added methods byValueAscending() and byValueDescending() to the SortArray class to support sorting simple array types (e.g., integers, strings) in ascending and descending order. - Updated tests to verify the correct functionality of sorting arrays by value. - Refactored SortArray to handle sorting of simple types without requiring a property for sorting. - Removed unnecessary whitespaces and formatting changes to ensure clean, readable code. For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/ Signed-off-by: Ranzy Blessings <ranzyblessings.inbox@gmail.com>
ranzyblessings
force-pushed
the
feature/SDMONGO-4929-sortarray-value-sorting
branch
from
bf38afb to
73f92a6
Compare
mp911de
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byValueAscending()andbyValueDescending()to the SortArray classto support sorting simple array types (e.g., integers, strings) in ascending and descending order.
For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/
Signed-off-by: Ranzy Blessings ranzyblessings.inbox@gmail.com