Skip to content

Remove parent observation key instead of setting null #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Remove parent observation key instead of setting null #5083

wants to merge 4 commits into from
+41 −34

Conversation

@mp911de
Copy link
Member

@mp911de mp911de commented Oct 27, 2025

When completing a MongoObservation without a parent observation, we now remove the parent observation key from the request context instead of setting it to null.

In reactive usage, the context map is a ConcurrentHashMap that does not allow null values.

Closes #5082

@mp911de mp911de added this to the 4.4.12 (2024.1.12) milestone Oct 27, 2025
@mp911de mp911de added type: regression A regression from a previous release type: bug A general bug labels Oct 27, 2025
@mp911de mp911de mentioned this pull request Oct 27, 2025
Closed
cweissbon
cweissbon approved these changes Oct 27, 2025
View reviewed changes
Copy link

@cweissbon cweissbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mp911de mp911de removed the type: bug A general bug label Oct 27, 2025
@mp911de @schauder
Prepare issue branch.
18ca693
@mp911de @schauder
Remove parent observation key instead of setting null.
b0efa15 
When completing a MongoObservation without a parent observation, we now remove the parent observation key from the request context instead of setting it to null.

In reactive usage, the context map is a ConcurrentHashMap that does not allow null values.
@schauder
Polishing.
9609b73 
Remove BDD comments.

Original pull request #5083
See #5082
schauder
schauder requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test doesn't seem to reproduce the underlying issue.

Let me know if you want me to look into this.

@mp911de
Polishing.
873cb5f 
Clean up residual observations after tests.
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Remove parent observation key instead of setting null.
41c3b25 
When completing a MongoObservation without a parent observation, we now remove the parent observation key from the request context instead of setting it to null.

In reactive usage, the context map is a ConcurrentHashMap that does not allow null values.

Closes #5082
Original pull request #5083
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Polishing.
bcbf2ff 
Clean up residual observations after tests.

See #5082
Original pull request #5083
schauder added a commit that referenced this pull request Oct 30, 2025
@schauder
Polishing.
75d2491 
Remove BDD comments.
Minor formatting.

Original pull request #5083
See #5082
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Remove parent observation key instead of setting null.
f7c9b7b 
When completing a MongoObservation without a parent observation, we now remove the parent observation key from the request context instead of setting it to null.

In reactive usage, the context map is a ConcurrentHashMap that does not allow null values.

Closes #5082
Original pull request #5083
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Polishing.
045f870 
Clean up residual observations after tests.

See #5082
Original pull request #5083
schauder added a commit that referenced this pull request Oct 30, 2025
@schauder
Polishing.
8002ab0 
Remove BDD comments.
Minor formatting.

Original pull request #5083
See #5082
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Remove parent observation key instead of setting null.
791d64f 
When completing a MongoObservation without a parent observation, we now remove the parent observation key from the request context instead of setting it to null.

In reactive usage, the context map is a ConcurrentHashMap that does not allow null values.

Closes #5082
Original pull request #5083
schauder pushed a commit that referenced this pull request Oct 30, 2025
@mp911de @schauder
Polishing.
03e7907 
Clean up residual observations after tests.

See #5082
Original pull request #5083
schauder added a commit that referenced this pull request Oct 30, 2025
@schauder
Polishing.
d83754e 
Remove BDD comments.
Minor formatting.

Original pull request #5083
See #5082
@schauder
Copy link
Contributor

Thanks, this is merged and ported back to supported OSS versions.

@schauder schauder closed this Oct 30, 2025
@mp911de mp911de deleted the issue/5082 branch October 30, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schauder schauder schauder requested changes

+1 more reviewer

@cweissbon cweissbon cweissbon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schauder schauder

@mp911de mp911de

@christophstrobl christophstrobl

Labels

type: regression A regression from a previous release

Projects

None yet

Milestone

4.4.12 (2024.1.12)

Development

Successfully merging this pull request may close these issues.

Reactive observation without parent fails with NullPointerException during completion

5 participants

@mp911de @schauder @cweissbon @christophstrobl