Skip to content

DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators #811

wants to merge 4 commits into from

Conversation

Ziemowit
Copy link
Contributor

Current state:

For now Criteria class allows to build or/and/nor operators in style:

operator(Criteria... c)

Requested change:

Criteria class should allow to build or/and/nor operators also in style (similar as it is possible for in/nin operators):

operator(Collection<Criteria> c)

@Ziemowit Ziemowit changed the title DATAMONGO-2428 - Add possibility to use Collection<Criteria> as param… DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators Nov 27, 2019
@Ziemowit
Copy link
Contributor Author

Hmm weird fail in Travis. I see it happened also for 2 previous pull requests. Is it some general issue or I made sth wrong?

@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@mp911de mp911de self-assigned this Feb 15, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2021
@mp911de mp911de linked an issue Feb 19, 2021 that may be closed by this pull request
Add possibility to use Collection<Criteria> as parameter in and/or/nor operators [DATAMONGO-2428] #3286
Closed
@mp911de mp911de added this to the 3.2 RC1 (2021.0.0) milestone Feb 19, 2021
mp911de pushed a commit that referenced this pull request Feb 19, 2021
@Ziemowit @mp911de
Add possibility to use Collection<Criteria> as parameter in and/or/no…
0b27635 
…r operators.

Closes #3286.
Original pull request: #811.
mp911de added a commit that referenced this pull request Feb 19, 2021
@mp911de
Polishing.
bcb5628 
Update javadoc, add since tags. Add non-null assertions. Introduce overload for type(…) accepting a collection

See #3286.
Original pull request: #811.
@mp911de
Copy link
Member

mp911de commented Feb 19, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Feb 19, 2021
@mp911de mp911de changed the title DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators DATAMONGO-2428 - Add possibility to use Collection<Criteria> as parameter in and/or/nor operators Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

3.2 M5 (2021.0.0)

Development

Successfully merging this pull request may close these issues.

Add possibility to use Collection<Criteria> as parameter in and/or/nor operators [DATAMONGO-2428]

3 participants

@Ziemowit @mp911de @spring-projects-issues