Skip to content

[DATAMONGO-2655] Add missing aggregate extension #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DATAMONGO-2655] Add missing aggregate extension #893

wants to merge 1 commit into from

Conversation

@wonwoo
Copy link
Contributor

@wonwoo wonwoo commented Nov 18, 2020

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@schauder schauder added type: enhancement A general enhancement in: kotlin Kotlin support and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 18, 2021
@mp911de mp911de self-assigned this Jan 27, 2021
@mp911de mp911de linked an issue Jan 27, 2021 that may be closed by this pull request
Add ReactiveMongoOperations.aggregate(…) Kotlin extension [DATAMONGO-2655] #3508
Closed
@mp911de mp911de added this to the 3.1.4 (2020.0.4) milestone Jan 27, 2021
mp911de pushed a commit that referenced this pull request Jan 27, 2021
@wonwoo @mp911de
Add missing ReactiveMongoOperations.aggregate Kotlin extension.
8bf3d39 
See #3508.
Original pull request: #893.
mp911de added a commit that referenced this pull request Jan 27, 2021
@mp911de
Polishing.
e1bce7d 
Align type variable naming with imperative extensions(I, O). Add extension without accepting KClass. Update since tags and tests.

See #3508.
Original pull request: #893.
mp911de pushed a commit that referenced this pull request Jan 27, 2021
@wonwoo @mp911de
Add missing ReactiveMongoOperations.aggregate Kotlin extension.
c11dcd1 
See #3508.
Original pull request: #893.
mp911de added a commit that referenced this pull request Jan 27, 2021
@mp911de
Polishing.
ce3066d 
Align type variable naming with imperative extensions(I, O). Add extension without accepting KClass. Update since tags and tests.

See #3508.
Original pull request: #893.
@mp911de
Copy link
Member

mp911de commented Jan 27, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

in: kotlin Kotlin support type: enhancement A general enhancement

Projects

None yet

Milestone

3.1.4 (2020.0.4)

Development

Successfully merging this pull request may close these issues.

Add ReactiveMongoOperations.aggregate(…) Kotlin extension [DATAMONGO-2655]

4 participants

@wonwoo @mp911de @schauder @spring-projects-issues