Skip to content

Add support for CONFIG REWRITE #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kender1314 opened this issue Mar 8, 2021 · 3 comments
Closed

Add support for CONFIG REWRITE #1992

kender1314 opened this issue Mar 8, 2021 · 3 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
2.5 RC1 (2021.0.0)

Comments

@kender1314
Copy link

kender1314 commented Mar 8, 2021 •
edited
Loading

Hi, I called the setConfig method in the RedisConnection class to modify some configurations, but I did not find the config rewrite command. It seems that this command is not supported. Will this command be supported in the future? How do I write the modified config into the configuration file now?
Thanks.
@kender1314
Copy link
Author

@mp911de

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2021
@kender1314
Copy link
Author

Hello，anyone there?

@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 15, 2021
@mp911de
Copy link
Member

mp911de commented Mar 15, 2021

Good catch. Feel free to submit a pull request to add this method.

@manousos manousos mentioned this issue Mar 22, 2021
Closed
@mp911de mp911de changed the title Config rewrite command is not supported Add support for CONFIG REWRITE Mar 29, 2021
@mp911de mp911de self-assigned this Mar 29, 2021
@mp911de mp911de added this to the 2.5 RC1 (2021.0.0) milestone Mar 29, 2021
mp911de added a commit that referenced this issue Mar 29, 2021
@mp911de
Polishing.
0f6a152 
Reorder methods. Move rewriteConfig directly implemented on connection to DefaultedRedisConnection respective DefaultedRedisClusterConnection.

Add overload to run config rewrite on individual cluster nodes. Add tests. Add since tags and update Javadoc.

See #1992
Original pull request: #2012.
@mp911de mp911de removed the status: ideal-for-contribution An issue that a contributor can help us with label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 RC1 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

Add support for CONFIG REWRITE manousos/spring-data-redis
3 participants
@mp911de @spring-projects-issues @kender1314