Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend properties for RedisSentinelConfiguration #2860

Closed
mustaphazorgati opened this issue Feb 29, 2024 · 0 comments
Closed

Extend properties for RedisSentinelConfiguration #2860

mustaphazorgati opened this issue Feb 29, 2024 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
3.3 M2 (2024.0.0)

Comments

@mustaphazorgati
Copy link
Contributor

While using the RedisSentinelConfiguration (reference: https://docs.spring.io/spring-data/redis/reference/redis/connection-modes.html#redis:sentinel), we discovered that the RedisSentinelConfiguration class has more configuration options that can be configured than the current set of properties.

In this issue, we want to extend the properties so that the RedisSentinelConfiguration can be fully configured via PropertySource.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 29, 2024
mustaphazorgati added a commit to mustaphazorgati/spring-data-redis that referenced this issue Feb 29, 2024
@mustaphazorgati @samuel-klose
Extend properties for RedisSentinelConfiguration.
51c7749 
Closes spring-projects#2860

Co-authored-by: Samuel Klose <39386136+samKl99@users.noreply.github.com>
mustaphazorgati added a commit to mustaphazorgati/spring-data-redis that referenced this issue Feb 29, 2024
@mustaphazorgati @samuel-klose
Extend properties for RedisSentinelConfiguration.
710ca3f 
Closes spring-projects#2860

Co-authored-by: Samuel Klose <39386136+samKl99@users.noreply.github.com>
@mustaphazorgati mustaphazorgati mentioned this issue Feb 29, 2024
Closed
4 tasks
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 1, 2024
@mp911de mp911de self-assigned this Mar 1, 2024
@mp911de mp911de added this to the 3.3 M2 (2024.0.0) milestone Mar 1, 2024
@mp911de mp911de closed this as completed in f9a763e Mar 1, 2024
mp911de added a commit that referenced this issue Mar 1, 2024
@mp911de
Polishing.
761115a 
Deprecate RedisSentinelConfiguration and RedisClusterConfiguration constructors taking PropertySource in favor of a factory method.

Reformat code. Update documentation.

See #2860
Original pull request: #2861
@mp911de mp911de changed the title RedisSentinelConfiguration properties are not complete Extend properties for RedisSentinelConfiguration Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.3 M2 (2024.0.0)
Development

Successfully merging a pull request may close this issue.

Extend properties for RedisSentinelConfiguration mustaphazorgati/spring-data-redis
3 participants
@mp911de @mustaphazorgati @spring-projects-issues