Skip to content

Added zRangeStoreByLex and zRangeStoreByScore for ZRANGESTORE c… #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Added zRangeStoreByLex and zRangeStoreByScore for ZRANGESTORE c… #2370

wants to merge 3 commits into from

Conversation

bytestreme
Copy link
Contributor

@bytestreme bytestreme commented Jul 16, 2022 •
edited
Loading

This PR adds support for ZRANGESTORE

Closes #2345

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Added zRangeStoreByLex and zRangeStoreByScore for ZRANGESTORE c…
df64b54 
…ommand in `RedisZSetCommands`, `ZSetOperations` and `StringRedisConnection`

Closes spring-projects#2345
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 16, 2022
@bytestreme
Copy link
Contributor Author

bytestreme commented Jul 16, 2022 •
edited
Loading

@mp911de Can you please take a look?

P.S. Should I include this into 3.0.0 or 2.7.3?

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 22, 2022
@mp911de mp911de self-assigned this Sep 22, 2022
@mp911de mp911de mentioned this pull request Sep 30, 2022
Closed
@mp911de mp911de added this to the 3.0 RC1 (2022.0.0) milestone Sep 30, 2022
mp911de pushed a commit that referenced this pull request Sep 30, 2022
@mp911de
Added zRangeStoreByLex and zRangeStoreByScore for ZRANGESTORE c…
40d078f 
…ommand.

Original pull request: #2370.
Closes #2345
mp911de added a commit that referenced this pull request Sep 30, 2022
@mp911de
Polishing.
62932e2 
Add reactive ZRANGESTORE support. Support rangeAndStore in RedisZSet.

Refine assertion messages. Refine overloads.

Original pull request: #2370.
See #2345
mp911de added a commit that referenced this pull request Sep 30, 2022
@mp911de
Refine methods accepting floating-point Range values.
d94e9e8 
For easier usage we now use Range<? extends Number> instead of Range<Number> to allow Range<Double> usage.

Original pull request: #2370.
Closes #2421
@mp911de
Copy link
Member

mp911de commented Sep 30, 2022

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 RC1 (2022.0.0)
Development

Successfully merging this pull request may close these issues.

Add support for ZRANGESTORE
3 participants
@bytestreme @mp911de @spring-projects-issues