Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect reference to SETNX in ReactiveValueOperations.setIfAbsent #3047

Closed
wants to merge 2 commits into from

Conversation

oxo1996
Copy link
Contributor

@oxo1996 oxo1996 commented Nov 19, 2024

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

The Javadoc for the setIfAbsent method in ReactiveValueOperations incorrectly references SETNX.
However, the implementation actually uses the SET command with the NX option.
This update aligns the documentation with the current implementation.

@pivotal-cla
Copy link

@oxo1996 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@oxo1996 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
marcingrzejszczak added a commit that referenced this pull request Nov 26, 2024
Updated more javadocs where reference to a Redis command was invalid.

Original pull request: #3047
marcingrzejszczak pushed a commit that referenced this pull request Nov 26, 2024
marcingrzejszczak added a commit that referenced this pull request Nov 26, 2024
Updated more javadocs where reference to a Redis command was invalid.

Original pull request: #3047
See: #3047
marcingrzejszczak pushed a commit that referenced this pull request Nov 26, 2024
marcingrzejszczak added a commit that referenced this pull request Nov 26, 2024
Updated more javadocs where reference to a Redis command was invalid.

Original pull request: #3047
See: #3047
marcingrzejszczak pushed a commit that referenced this pull request Nov 26, 2024
marcingrzejszczak added a commit that referenced this pull request Nov 26, 2024
Updated more javadocs where reference to a Redis command was invalid.

Original pull request: #3047
See: #3047
@mp911de mp911de added this to the 3.3.7 (2024.0.7) milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants