Skip to content

Add support for microseconds using TIME #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add support for microseconds using TIME #526

wants to merge 6 commits into from

Conversation

hsoftxl
Copy link

@hsoftxl hsoftxl commented Apr 26, 2020

support get microseconds

mp911de
mp911de requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, sorry for the long radio silence. I reviewed this PR and left a few comments to be addressed.

@hsoftxl hsoftxl requested a review from mp911de November 10, 2020 07:09
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2021
@mp911de mp911de self-assigned this Mar 1, 2021
mp911de added a commit that referenced this pull request Mar 2, 2021
@mp911de
Add support for microseconds using TIME.
c592bfa 
Original pull request: #526.
@mp911de
Copy link
Member

mp911de commented Mar 3, 2021

Thanks for the pull request. During the merge, we found that the implementation could be streamlined towards overloaded time methods accepting TimeUnit. Therefore we went for a slightly different approach.

@mp911de mp911de closed this Mar 3, 2021
mp911de added a commit that referenced this pull request Mar 3, 2021
@mp911de
Add support for microseconds using TIME.
02db9aa 
Closes #526.
Original pull request: #526.
@mp911de mp911de changed the title support microseconds Add support for microseconds using TIME Mar 3, 2021
@mp911de mp911de added this to the 2.5 RC1 (2021.0.0) milestone Mar 3, 2021
mp911de added a commit that referenced this pull request Mar 3, 2021
@mp911de
Add support for microseconds using TIME.
102ee01 
Closes #526.
Original pull request: #526.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M5 (2021.0.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@hsoftxl @mp911de @spring-projects-issues