Skip to content

Allow for arbitrary conditions as join condition. #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Allow for arbitrary conditions as join condition. #1014

wants to merge 3 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Jul 22, 2021 •
edited
Loading

This is rebased onto #1018, please review that first.

Closes #995

@schauder schauder requested a review from gregturn July 22, 2021 07:31
mp911de
mp911de reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding conditions turned out it a pretty small change in exchange for much more increased flexibility.

@schauder
Copy link
Contributor Author

Adding conditions turned out it a pretty small change in exchange for much more increased flexibility.

Yeah, that was a nice surprise for a change.

schauder added a commit that referenced this pull request Jul 22, 2021
@schauder
Fix and improve JavaDoc based on review comments.
6cfa4ca 
See #1009
Original pull request #1014
schauder added a commit that referenced this pull request Jul 30, 2021
@schauder
Fix and improve JavaDoc based on review comments.
704e54f 
See #1009
Original pull request #1014
@schauder schauder force-pushed the issue/995-non-trivial-join-condition branch from 6cfa4ca to 704e54f Compare July 30, 2021 06:08
@schauder schauder mentioned this pull request Jul 30, 2021
Closed
@gregturn
Copy link
Contributor

I almost need to review this after #1018 is completed, so I can see what's unique here.

@mp911de mp911de force-pushed the issue/995-non-trivial-join-condition branch from 704e54f to 391293e Compare September 28, 2021 12:28
mp911de pushed a commit that referenced this pull request Sep 28, 2021
@schauder @mp911de
Allow for arbitrary conditions as join condition.
82c70ab 
Closes #995.
Original pull request: #1014.
mp911de added a commit that referenced this pull request Sep 28, 2021
@mp911de
Polishing.
9844f40 
Reformat code. Add since tag.

See #995
Original pull request: #1014.
@mp911de mp911de added the type: enhancement A general enhancement label Sep 28, 2021
@mp911de mp911de self-assigned this Sep 28, 2021
@mp911de mp911de added this to the 2.3 RC1 (2021.1.0) milestone Sep 28, 2021
@mp911de
Copy link
Member

mp911de commented Sep 28, 2021

That's merged and polished now.

@mp911de mp911de closed this Sep 28, 2021
@mp911de mp911de deleted the issue/995-non-trivial-join-condition branch September 28, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de mp911de left review comments

@gregturn gregturn Awaiting requested review from gregturn

Assignees

@gregturn gregturn

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.3 RC1 (2021.1.0)

Development

Successfully merging this pull request may close these issues.

SelectBuilder makes assumptions about join conditions being "trivial"

3 participants

@schauder @gregturn @mp911de