Skip to content

Add insertAll and updateAll for JdbcAggregateOperations #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add insertAll and updateAll for JdbcAggregateOperations #1396

wants to merge 1 commit into from

Conversation

@mhyeon-lee
Copy link
Contributor

@mhyeon-lee mhyeon-lee commented Dec 17, 2022 •
edited
Loading

#1395

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 17, 2022
schauder
schauder requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks pretty good.
I have only two (mostly identical) requests.

See the comments.

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateOperations.java Outdated
* @param instances the aggregate roots to be inserted. Must not be {@code null}.
* @param <T> the type of the aggregate root.
* @return the saved instances.
* @throws IncorrectUpdateSemanticsDataAccessException when at least one instance is determined to be not new.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this coming from? If this is the case we should have a test for it. And it probably would be the same for the simple insert method, where we should add that documentation and the test as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schauder
I used saveAll method of document .
That was an incorrect explanation. It's my fault.

Edited document.
Feel free to edit it with a better description.

thank you

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/JdbcAggregateOperations.java Outdated
* @param instances the aggregate roots to be inserted. Must not be {@code null}.
* @param <T> the type of the aggregate root.
* @return the saved instances.
* @throws IncorrectUpdateSemanticsDataAccessException when at least one instance is determined to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@schauder schauder linked an issue Dec 21, 2022 that may be closed by this pull request
Add insertAll and updateAll JdbcAggregateOperations with batch execution #1395
Closed
@mhyeon-lee mhyeon-lee force-pushed the add-insert-update-all-for-jdbc-aggregate-template branch from ebfa073 to 41524ea Compare December 22, 2022 14:39
schauder pushed a commit that referenced this pull request Dec 22, 2022
@mhyeon-lee @schauder
Add insertAll and updateAll for JdbcAggregateOperations.
d10be27 
Original pull request #1396
Closes #1395
schauder added a commit that referenced this pull request Dec 22, 2022
@schauder
Polishing.
fb9a4f3 
Original pull request #1396
See #1395
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 22, 2022
@schauder
Copy link
Contributor

Thanks, that's merged.

@schauder schauder closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schauder schauder schauder requested changes

Assignees

No one assigned

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

3.1 M1 (2023.0.0)

Development

Successfully merging this pull request may close these issues.

Add insertAll and updateAll JdbcAggregateOperations with batch execution

3 participants

@mhyeon-lee @schauder @spring-projects-issues