Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RowDocumentIterator's hasNext implementation. #1615

Closed
wants to merge 2 commits into from
Closed

Fix RowDocumentIterator's hasNext implementation. #1615

wants to merge 2 commits into from

Commits on Sep 19, 2023

  1. fix-RowDocumentResultSetExtractor - Prepare branch

    @schauder
    schauder committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b2ecc54 View commit details
    Browse the repository at this point in the history

  2. Fix RowDocumentIterator's hasNext implementation. 

    This properly fixes the test setup, taking into account that @ActiveProfile by default replaces any profiles set via environment variable or system property.
It turns out that the hasNext calculation in RowDocumentIterator was wrong because

a) isBeforeFirst and isBeforeLast return both false when the ResultSet is empty.
b) isBeforeFirst and isBeforeLast aren't necessarily implemented for all ResultSets and for example DB2s ResultSet implementation don't support it by default.
    @schauder
    schauder committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    929c124 View commit details
    Browse the repository at this point in the history