[WIP] Use force-quoting in R2dbcMappingContext by default #2047
+157
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: enhancement
|
Please do not merge this PR. It is not yet fully edited, and it is very likely that it will not be further edited. |
schauder
requested changes
Apr 29, 2025
There was a problem hiding this comment.
When I realized how many changes were required to support this, I started to feel that my approach might be flawed.
There shouldn't really be that many changes.
What I would expect is the change to the default configuration, i.e. the R2dbcMappingContext and then tons of changes to the tests, since most of them use the default, which we are changing.
Everything else should stay the same, since we already support forced quoting if so configured.
Could you line out why you think you have to change so much more?
| @@ -26,6 +26,7 @@ | |||
| import java.util.function.Supplier; | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| import org.jetbrains.annotations.TestOnly; | |||
There was a problem hiding this comment.
We are not using this annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I realized how many changes were required to support this, I started to feel that my approach might be flawed. Given that I don't fully understand the design, I felt that I shouldn't make such extensive modifications without fully understanding it.
In my understanding, when transforming an AST into SQL, special handling (such as formatting, ignoring comments, or quoting) is usually applied through a visitor.
However, in the current Spring implementation, the quoting behavior is decided at AST generation time rather than during SQL rendering.
This design means that if the quoting strategy needs to change, all related code must be modified, which increases the risk of omissions. Additionally, it is difficult to be certain which places do not require changes.
Therefore, I have temporarily put this work on hold and am seeking a better solution from the community.
@schauder suggested that I submit a PR to ensure that this issue is not missed in #1993