-
Notifications
You must be signed in to change notification settings - Fork 373
Add Ahead of Time Repository support #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eb6f33b
Prepare issue branch.
mp911de d83d1f6
Move off deprecated AOT API.
mp911de 37bcf25
Add Ahead of Time Repository support.
mp911de b174ffc
Address review comments.
mp911de 9536eb7
Review findings.
mp911de 8a0447a
Experiment with better code blocks.
mp911de ee350f5
Add better comments, refine naming.
mp911de File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/aot/AotQueries.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
/* | ||
* Copyright 2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.springframework.data.jdbc.repository.aot; | ||
|
||
import java.util.LinkedHashMap; | ||
import java.util.Map; | ||
|
||
import org.jspecify.annotations.Nullable; | ||
|
||
import org.springframework.data.repository.aot.generate.QueryMetadata; | ||
|
||
/** | ||
* Value object capturing queries used for repository query methods. | ||
* | ||
* @author Mark Paluch | ||
* @since 4.0 | ||
*/ | ||
record AotQueries(AotQuery result, @Nullable AotQuery count) { | ||
|
||
/** | ||
* Factory method to create an {@link AotQueries} instance with a single query. | ||
* | ||
* @param query | ||
* @return | ||
*/ | ||
public static AotQueries create(AotQuery query) { | ||
return new AotQueries(query, null); | ||
} | ||
|
||
/** | ||
* Factory method to create an {@link AotQueries} instance with an entity- and a count query. | ||
* | ||
* @param query | ||
* @param count | ||
* @return | ||
*/ | ||
public static AotQueries create(AotQuery query, AotQuery count) { | ||
return new AotQueries(query, count); | ||
} | ||
|
||
public QueryMetadata toMetadata() { | ||
return new AotQueryMetadata(); | ||
} | ||
|
||
/** | ||
* String and Named Query-based {@link QueryMetadata}. | ||
*/ | ||
private class AotQueryMetadata implements QueryMetadata { | ||
|
||
@Override | ||
public Map<String, Object> serialize() { | ||
|
||
Map<String, Object> serialized = new LinkedHashMap<>(); | ||
|
||
if (result() instanceof StringAotQuery sq) { | ||
serialized.put("query", sq.getQueryString()); | ||
} | ||
|
||
if (result() instanceof StringAotQuery.NamedStringAotQuery nsq) { | ||
serialized.put("name", nsq.getQueryName()); | ||
} | ||
|
||
if (count() instanceof StringAotQuery sq) { | ||
serialized.put("count-query", sq.getQueryString()); | ||
} | ||
|
||
if (count() instanceof StringAotQuery.NamedStringAotQuery nsq) { | ||
serialized.put("count-name", nsq.getQueryName()); | ||
} | ||
|
||
return serialized; | ||
} | ||
|
||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we missing a
@Nullable
annotation here, or is theobject != null
check superfluous?