Skip to content

Conversation

tomek82
Copy link

@tomek82 tomek82 commented Aug 22, 2025

This is a counterpart to #1865

In cases where the child of a MappedCollection maps the id or key column the select clause will have duplicate entries and thus generate the ResultSet warning in RowDocumentResultSetExtractor.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Signed-off-by: Tomasz Bielecki <tomasz.bielecki@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 22, 2025
@tomek82 tomek82 closed this Aug 22, 2025
@tomek82
Copy link
Author

tomek82 commented Aug 22, 2025

Apologies, I did not notice this has been changed since I've started working on this issue. Does not seem to reproduce on latest main. Perhaps this could be considered for 3.5.x?

@tomek82 tomek82 reopened this Aug 22, 2025
@tomek82 tomek82 changed the base branch from main to 3.5.x August 22, 2025 04:40
@schauder
Copy link
Contributor

#1865 is closed. If there still is a problem we first need a new issue with a reproducer.

@schauder schauder added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 22, 2025
@tomek82
Copy link
Author

tomek82 commented Aug 22, 2025

Is the unit test in the PR not enough? I can provide a sample project that shows this behavior if needed. It's still an issue on 3.5.3.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 22, 2025
@schauder
Copy link
Contributor

I can provide a sample project that shows this behavior if needed.

Please do so.

schauder pushed a commit that referenced this pull request Aug 27, 2025
This fixes #1865 for derived queries.

Signed-off-by: Tomasz Bielecki <tomasz.bielecki@gmail.com>

Original pull request #2125
See #1865
schauder added a commit that referenced this pull request Aug 27, 2025
Avoiding var.
Referencing issue/pr in tests.
Formatting.

See #2125
See #1865
schauder pushed a commit that referenced this pull request Aug 27, 2025
This fixes #1865 for derived queries.

Signed-off-by: Tomasz Bielecki <tomasz.bielecki@gmail.com>

Original pull request #2125
See #1865
schauder added a commit that referenced this pull request Aug 27, 2025
Avoiding var.
Referencing issue/pr in tests.
Formatting.

See #2125
See #1865
@schauder
Copy link
Contributor

That's merged into 3.5.x and 3.4.x.

Thanks for your support.

@schauder schauder closed this Aug 27, 2025
@schauder schauder added type: bug A general bug and removed status: feedback-provided Feedback has been provided labels Aug 27, 2025
@schauder schauder added this to the 3.4.10 (2024.1.10) milestone Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants