Deprecate methods accepting Query and Pageable returning Page
#2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both the Query and the Pageable have limit, offset and sorting information, these methods are confusing and the strategy to resolve the conflict is not clear. Existing code using the methods got replaced. Users of these methods should use the various findAll and findBy methods to construct Page objects as desired. Closes #2138
mp911de
reviewed
Oct 23, 2025
|
|
||
| private Query applyPageable(Query query, Pageable pageable) { | ||
|
|
||
| if (pageable.isPaged()) { |
There was a problem hiding this comment.
Any reason to not use Query.with(Pageable)?
There was a problem hiding this comment.
Of course! Lack of knowledge 8-)
mp911de
pushed a commit
that referenced
this pull request
Oct 23, 2025
Since both the Query and the Pageable have limit, offset and sorting information, these methods are confusing and the strategy to resolve the conflict is not clear. Existing code using the methods got replaced. Users of these methods should use the various findAll and findBy methods to construct Page objects as desired. Closes #2138 Original pull request #2161
mp911de
pushed a commit
that referenced
this pull request
Oct 23, 2025
Since both the Query and the Pageable have limit, offset and sorting information, these methods are confusing and the strategy to resolve the conflict is not clear. Existing code using the methods got replaced. Users of these methods should use the various findAll and findBy methods to construct Page objects as desired. Closes #2138 Original pull request #2161
mp911de
changed the title
Query and Pageable returning Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both the Query and the Pageable have limit, offset and sorting information, these methods are confusing and the strategy to resolve the conflict is not clear.
Existing code using the methods got replaced.
Users of these methods should use the various findAll and findBy methods to construct Page objects as desired.
Closes #2138