Skip to content

Handle ConstantCondition in ConditionVisitor. #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

danielecanteri
Copy link
Contributor

Added support for ConstantConditions in ConditionVisitor.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 14, 2021
@danielecanteri danielecanteri changed the title Handle ConstantCondition in ConditionVisitor. DATAJDBC-907 Handle ConstantCondition in ConditionVisitor. May 14, 2021
@schauder schauder changed the title DATAJDBC-907 Handle ConstantCondition in ConditionVisitor. Handle ConstantCondition in ConditionVisitor. May 17, 2021
@schauder schauder self-assigned this May 17, 2021
schauder pushed a commit that referenced this pull request May 17, 2021
schauder added a commit that referenced this pull request May 17, 2021
Fixes copyright dates of new files to the current year.
Fixes the issue reference to use the GitHub notation.
Adds an additional test to ensure that the `ConstantConditionVisitor` doesn't need a predicate.

Original pull request #978
@schauder
Copy link
Contributor

Thanks for resolving this issue.

A few minor comments for future PRs (I fixed these for this one).
DATAJDBC-xxx refers to the old Jira issue tracker, that we no longer use. Use GitHubs #xxx instead.
Copyright of new files should always be the current year only.

Thanks again.

@schauder schauder closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.springframework.data.relational.core.sql.render.ConditionVisitor does not handle ConstantConditions
3 participants