Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarshallingView should override AbstractView instead of AbstractUrlBasedView [SPR-5380] #10053

Closed
spring-projects-issues opened this issue Jan 1, 2009 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Fabio Grassi opened SPR-5380 and commented

It appears to me that MarshallingView doesn't use the url property at all. Being url management the only addition that AbstractUrlBasedView intoduces over AbstractView, I think that MarshallingView shoul really inherit from the latter, thus sparing the user from having to set a dummy value for the url, which is required.


Referenced from: commits e863f9a

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Given that we're moving oxm to the Spring Framework, I've moved this issue over as well.

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed! Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants