Possible NPE in JmsUtils.buildExceptionMessage and JmsException.getMessage [SPR-5470]

[spring-projects-issues]

Guillaume Nodet opened SPR-5470 and commented

If the JMS exception has no message, a NPE is thrown

Exception in thread "org.apache.servicemix.jbi.cluster.requestor.ActiveMQJmsRequestorPool#717dc9-3" java.lang.NullPointerException
        at java.lang.String.indexOf(String.java:1564)
        at java.lang.String.indexOf(String.java:1546)
        at org.springframework.jms.support.JmsUtils.buildExceptionMessage(JmsUtils.java:255)
        ...

---

Affects: 2.5.6

Issue Links:

• JmsUtils.buildExceptionMessage throws NPE if the linked exception doesn't have a message [SPR-5275] #9948 JmsUtils.buildExceptionMessage throws NPE if the linked exception doesn't have a message ("duplicates")

[spring-projects-issues]

Juergen Hoeller commented

I'm reopening this issue for the linked exception problem that you pointed out at #9948.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

Should be fully fixed for M2 now, in both JmsException and JmsUtils.

Juergen

[spring-projects-issues]

Philippe Mouawad commented

Hello,
Is it possible to apply this correction on 2.5.X family ?

Thank you in advance.
Philippe
http://www.ubik-ingenierie.com

[spring-projects-issues]

Sven Borkert commented

Hello,

this error prevents "DefaultMessageListenerContainer" from recovering broken connections. I tested this with active MQ, when I shutdown the broker, NPEs appear:

Exception in thread "commandListener-3" java.lang.NullPointerException
at java.lang.String.indexOf(String.java:1733)
at java.lang.String.indexOf(String.java:1715)
at org.springframework.jms.support.JmsUtils.buildExceptionMessage(JmsUtils.java:255)
at org.springframework.jms.listener.DefaultMessageListenerContainer.handleListenerSetupFailure(DefaultMessageListenerContainer.java:745)
at org.springframework.jms.listener.DefaultMessageListenerContainer$AsyncMessageListenerInvoker.run(DefaultMessageListenerContainer.java:897)
at java.lang.Thread.run(Thread.java:637)

This causes the thread to die, and I think it stays unnoticed, so there is no recovery.

How can you not fix such bugs in the stable version, when Spring 3 is only available as RC and not stable?

Regards,

Sven

[spring-projects-issues]

Dennis Homann commented

I agree with Philippe: please backport this fix to 2.5.x.
See #12168.

[spring-projects-issues]

Timothy Myer commented

+1 for backporting to Spring 2.5.x.