Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelAndView.getModel method garbages wasCleared state [SPR-5505] #10177

Closed
spring-projects-issues opened this issue Feb 18, 2009 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

miceuz opened SPR-5505 and commented

I have two interceptors in my HandlerMapping:

OpenSessionInViewInterceptor and
legacy xt ajax interceptor that utilizes postHandle method and uses ModelAndView returned from controller to get command object - i.e. i can't return null from controller, i need modelAndView in interceptor.

the problem is that i get "javax.servlet.ServletException: ModelAndView [ModelAndView: materialized View is [null]; model is {}] neither contains a view name nor a View object" exceotion in DispatcherServlet after ajax submit event.

My ajax interceptor prepares the response and clears ModelAndView, but WebRequestHandlerInterceptorAdapter, which wraps OpenSessionInViewInterceptor calls getModel() on my modelAndView object. This creates an empty model map in modelNadView:

public ModelMap getModelMap() {
if (this.model == null) {
this.model = new ModelMap();
}
return this.model;
}

and modelAndView.wasCleared() is no longer true.


Affects: 2.5.6

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Thanks for pointing this out! Fixed as of 3.0 M2.

Juergen

@spring-projects-issues spring-projects-issues added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants