@Autowired vs. @Resource [SPR-5579]

[spring-projects-issues]

Paul Bacsik opened SPR-5579 and commented

@Autowired public void setDataSource(DataSource ds) does not wire when default-autowire="true" and there exists more DataSource beans e.g with ids dataSource, someOtherDS1, someOtherDS2.

Declaring @Resource public void setDataSource(DataSource ds) works.

It seams @Autowired can't resolve the PropertyName, maybe ist searches the parameter name 'ds', but since this is a Property Setter, this is not the desired behaviour.

---

Affects: 2.5.6

Issue Links:

• Use field or parameter name as default value for @Qualifier [SPR-5152] #9825 Use field or parameter name as default value for @Qualifier

[spring-projects-issues]

Juergen Hoeller commented

This is by design, actually: @Autowired does not handle bean property setters in a special way but rather resolves its argument by type and qualifiers. In your scenario, @Autowired @Qualifier("dataSource") would work since the target bean name is used as a default qualifier String then.

We do plan to revisit this for Spring 3.0, also for using the field name as a default qualifier value.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

The basic arrangement won't change in Spring 3.0 either: @Autowired will still be agnostic in terms of the methods that it operates on. We may just use the parameter name as default qualifier value. If you prefer to use property resolution specifically for single-arg setter methods following the JavaBeans naming convention, then the recommendation is indeed to use @Resource. Alternatively, simply add a @Qualifier value to your @Autowired method.

Juergen