ClassCastException in WebRequestDataBinder with MultipartRequest [SPR-6136]

[spring-projects-issues]

Dave Syer opened SPR-6136 and commented

ClassCastException in WebRequestDataBinder with MultipartRequest. In bind() method:

if (request instanceof NativeWebRequest) {
     Object nativeRequest = ((NativeWebRequest) request).getNativeRequest();
     if (nativeRequest instanceof MultipartRequest) {
          MultipartRequest multipartRequest = (MultipartRequest) request;
          bindMultipartFiles(multipartRequest.getFileMap(), mpvs);
     }
}

should be

if (request instanceof NativeWebRequest) {
     Object nativeRequest = ((NativeWebRequest) request).getNativeRequest();
     if (nativeRequest instanceof MultipartRequest) {
          MultipartRequest multipartRequest = (MultipartRequest) nativeRequest;
          bindMultipartFiles(multipartRequest.getFileMap(), mpvs);
     }
}

---

No further details from SPR-6136

[spring-projects-issues]

Juergen Hoeller commented

Funny coincidence - I've just encountered the very same piece of code this morning, replacing it with some direct MultipartRequest support on the NativeWebRequest interface itself. We're using WebRequestDataBinder as the default binder for all @MVC processing now, so I guess that's why its deficiencies are suddenly showing now...

Juergen