Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location parsing might incorrectly rely on the URL API [SPR-6332] #10998

Closed
spring-projects-issues opened this issue Nov 11, 2009 · 1 comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 11, 2009

Costin Leau opened SPR-6332 and commented

It's worth double checking whether the way resource locations are parsed throughout Spring rely on the URL API or not since the former can create false positives. Using the URI API is a better solution as it doesn't perform validation.


Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

Costin Leau commented

After looking at both ResourceUtils#isUrl and ResourcePatternUtils#isUrl, I've came to the conclusion that these methods are in a correct way. Since in most cases, the location is opened as stream (and thus through an URL), transforming the validation into parsing would not provide any gains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant