Remove unreachable code from TransactionTemplate [SPR-10148]

[spring-projects-issues]

Elad Tabak opened SPR-10148 and commented

The method org.springframework.transaction.support.TransactionTemplate.exectue() have dead code where calling upon the TransactionCallback.doInTransaction() is surrounded with 'try/catch', only the last "catch" for "Exception" is unnecessary, since the "doInTransaction()" does not declare any checked exception to be thrown.
The last "catch" statement is actually dead/unreachable code, since only RuntimeExceptions and Errors can be thrown from the "doInTransaction" method.

---

Affects: 3.1.3

Issue Links:

• TransactionTemplate leaks transactions when TransactionCallback propagates undeclared checked exception [SPR-6361] #11027 TransactionTemplate leaks transactions when TransactionCallback propagates undeclared checked exception

[spring-projects-issues]

Juergen Hoeller commented

It's odd but this catch Exception block is necessary since reflectively called constructors in a TransactionCallback implementation may leak a catched Exception even through a signature that doesn't declare it. See #11027.

Juergen

[spring-projects-issues]

Elad Tabak commented

When you say "reflectively called constructors", do you mean Class.newInstance() methods? if that is the case then newInstance() throws InstantiationException which is checked exception, hence the TransactionCallback implementation won't compile.

I can see a possible case where you place a java proxy as callback, and the invoke method (of InvocationHandler) can throw Throwable, which may be checked exception.

[spring-projects-issues]

Juergen Hoeller commented

See the test case attached to #11027: It seems odd but it actually does make a difference.

Juergen